Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade utrecht components #5143

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Upgrade utrecht components #5143

merged 2 commits into from
Mar 7, 2025

Conversation

sergei-maertens
Copy link
Member

Part of open-formulieren/open-forms-sdk#445 (updating dependencies)

Changes

  • Updated to latest @utrecht/components
  • Updated to compatible design-tokens package

Note that this package is no longer being published in favour of individual components - that's going to be another undertaking for some future day.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled

  • Release management

    • I have labelled the PR as "needs-backport" accordingly

  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh

  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder

  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@sergei-maertens sergei-maertens requested a review from vaszig March 6, 2025 20:22
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.74%. Comparing base (1fc9168) to head (ea227c4).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5143   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files         778      778           
  Lines       26745    26745           
  Branches     3476     3476           
=======================================
  Hits        25875    25875           
  Misses        607      607           
  Partials      263      263

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sergei-maertens sergei-maertens merged commit 53e2f7c into master Mar 7, 2025
33 checks passed
@sergei-maertens sergei-maertens deleted the chore/upgrade-utrecht-components branch March 7, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaszig vaszig vaszig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergei-maertens @vaszig